-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport Fixes for react 0.69.X on branch react-native-video 5.2 #2795
Conversation
Starting with React Native 0.68, using Prop Types from `react-native` emits a warning.
Co-authored-by: Elliott Kember <elliott.kember@gmail.com> # Conflicts: # Video.js
# Conflicts: # Video.js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working on 0.69.4
Tested on 0.69.4 and it's working ✔️ |
+1 we need this update ASAP 🙏 , tested in 0.69.4 |
When is this going in?? |
Should done during next week |
@@ -22,5 +22,5 @@ android { | |||
dependencies { | |||
//noinspection GradleDynamicVersion | |||
implementation "com.facebook.react:react-native:${safeExtGet('reactNativeVersion', '+')}" | |||
implementation 'com.yqritc:android-scalablevideoview:1.0.4' | |||
implementation 'com.github.adityaxjha:Android-ScalableVideoView:10e7b4da8b' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is this?
This pull request fixes the problem #2818 that I was having. |
Can we please merge this? a real world app is depending on this issue, not working the alpha branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
This PR is now branch 5.2.X, let's close it |
Describe the changes